Skip to content

Week 06 - Jun 22-28

Focus: PR #879 merge, navigation screenshots, and PR #894 for #790

What changed

  • Reordered Week 6 around evidence before code.
  • PR #879 merged after the corrected Amigo contrast scope was documented.
  • Checked touch-target sizing against the keypad and touch menu formulas. Current TZT and Amigo targets clear the 24px minimum, while several stay below the 44px enhanced target size.
  • Rechecked layout against current source and the published screenshots. The finding count did not change: 0 critical, 0 high, 2 medium, and 4 low.
  • Redid the text legibility audit as a three-tier pass. The active text capacity is tighter than the older table showed, but the finding count stayed at 0 critical, 0 high, 0 medium, and 1 low.
  • Rechecked overlap with #771 and #797 before code. Both still touch the menu, keypad, or touch surfaces, so a touch-target PR would need a stronger reason.
  • Redid the navigation audit around flow depth, touch target size, back/escape clarity, and button-only input effort.
  • Captured targeted simulator evidence for the #790 issue follow-up on TZT, Amigo, and M5StickV, plus final scoped captures for TZT and M5StickV.
  • Opened PR #894 for #790 with a Home Settings entry that exposes only Printer and Encryption.

Current decision

At the end of Week 6, the current PR was #894 for #790. It was narrow, open, and already had a clear issue scope: a Home Settings entry scoped only to Printer and Encryption.

PR #879 is now the completed first contribution lane. #790 is still an open issue while PR #894 is reviewed upstream.

Later Week 7 review changed the tradeoff: PR #894 may be parked unless maintainers want the post-wallet fallback case enough to spend a permanent Home menu item on it.

Verification

  • Touch targets: source-derived measurements, TZT/Amigo simulator screenshot references, and live #771/#797 overlap check.
  • Layout: source-derived L1-L6 recheck, screenshot hash comparison, and visual inspection of the three published layout evidence images.
  • Legibility: source-derived display metrics, focused display wrapping tests, and a curated three-device screenshot evidence set.
  • Issue #790: targeted Home -> Settings evidence was captured on TZT, Amigo, and M5StickV for PR #894.

Next

  • Respond to review feedback on PR #894.
  • Keep the PR wording tied to #790 only, not the wider navigation findings.
  • Ask mentors which navigation or hardware-follow-up lane should come next.